Paul Bolle <pebolle@xxxxxxxxxx> writes: > Vinod already applied this, so my remarks, if valid, should probably be > handled in a follow up patch. > >> +module_platform_driver(pxad_driver); > > (The series starting at https://lkml.org/lkml/2015/5/10/131 would allow > to use builtin_platform_driver() for built-in only code.) I won't be that way for forever, see next comment. >> +MODULE_DESCRIPTION("Marvell PXA Peripheral DMA Driver"); >> +MODULE_AUTHOR("Robert Jarzmik <robert.jarzmik@xxxxxxx>"); >> +MODULE_LICENSE("GPL v2"); > > This patch added a bool Kconfig symbol. So pxa_dma.c will never be part > of a module. > Its code contains a few module specific macros. Was it actually intended for > PXA_DMA to be tristate? It is designed to be a module, and in the "end" it will be a module. What is important to understand is the 3 phases which are going to happen : - phase 1 : state after this is merged pxa_dma must be builtin, for legacy support (see pxad_toggle_reserved_channel()). - phase 2 : slowly, all the pxa drivers are converted to dmaengine - phase 3 : after full conversion, the patch "add support for legacy transition" is reverted. There pxa_dma will become modular, and the tristate will appear. In conclusion, it cannot be a module yet, but it will in the future. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
