On Mon, May 18, 2015 at 02:16:14PM +0530, Vinod Koul wrote: > > +static enum dma_status sun4i_dma_tx_status(struct dma_chan *chan, > > + dma_cookie_t cookie, > > + struct dma_tx_state *state) > > +{ > > + struct sun4i_dma_vchan *vchan = to_sun4i_dma_vchan(chan); > > + struct sun4i_dma_pchan *pchan = vchan->pchan; > > + struct sun4i_dma_contract *contract; > > + struct sun4i_dma_promise *promise; > > + struct virt_dma_desc *vd; > > + unsigned long flags; > > + enum dma_status ret; > > + size_t bytes = 0; > > + > > + ret = dma_cookie_status(chan, cookie, state); > > + if (ret == DMA_COMPLETE) > > + return ret; > > Pls check if state is valid before progressing ahead Just one more question about this one. What should we return in the case where state would be NULL ? DMA_ERROR? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature