[PATCH] dma: at_xdmac: use __le32 for dma addresses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The at_xdmac uses a lli structure with a mix of dma_addr_t and __le32
in it. As Russell King pointed out, dma_addr_t could be a non 32-bit
size depending on the kernel configuration. Change all references of
this to __le32 to better match the hardware representation.

Note, this does nothing to fix the discussion of dma vs physical
addresses also brought up during these discussions.

This patch depends on the __le32 descriptor updates posted
previously.

Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
--
CC: Russell King <linux@xxxxxxxxxxxxxxxx>
CC: Nicolas Ferre <nicolas.ferre@xxxxxxxxx>
CC: Dan Williams <dan.j.williams@xxxxxxxxx>
CC: Vinod Koul <vinod.koul@xxxxxxxxx>
CC: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
CC: dmaengine@xxxxxxxxxxxxxxx
---
 drivers/dma/at_xdmac.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 65a37be..d9dd71c 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -231,10 +231,10 @@ struct at_xdmac {
 
 /* Linked List Descriptor */
 struct at_xdmac_lld {
-	dma_addr_t	mbr_nda;	/* Next Descriptor Member */
+	__le32		mbr_nda;	/* Next Descriptor Member */
 	__le32		mbr_ubc;	/* Microblock Control Member */
-	dma_addr_t	mbr_sa;		/* Source Address Member */
-	dma_addr_t	mbr_da;		/* Destination Address Member */
+	__le32		mbr_sa;		/* Source Address Member */
+	__le32		mbr_da;		/* Destination Address Member */
 	__le32		mbr_cfg;	/* Configuration Register */
 };
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux