On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:
> Instead of magic numbers in the code, use define for number of logical DMA
> channels and DMA requests.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
> drivers/dma/omap-dma.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 7dd6dd121681..56c33e93dd24 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -22,6 +22,9 @@
>
> #include "virt-dma.h"
>
> +#define OMAP_SDMA_REQUESTS 127
> +#define OMAP_SDMA_CHANNELS 32
Again why dont we put these things in DT ?
--
~Vinod
> +
> struct omap_dmadev {
> struct dma_device ddev;
> spinlock_t lock;
> @@ -33,7 +36,7 @@ struct omap_dmadev {
> bool legacy;
> spinlock_t irq_lock;
> uint32_t irq_enable_mask;
> - struct omap_chan *lch_map[32];
> + struct omap_chan *lch_map[OMAP_SDMA_CHANNELS];
> };
>
> struct omap_chan {
> @@ -1115,7 +1118,7 @@ static int omap_dma_probe(struct platform_device *pdev)
>
> tasklet_init(&od->task, omap_dma_sched, (unsigned long)od);
>
> - for (i = 0; i < 127; i++) {
> + for (i = 0; i < OMAP_SDMA_REQUESTS; i++) {
> rc = omap_dma_chan_init(od, i);
> if (rc) {
> omap_dma_free(od);
> --
> 2.3.0
>
--
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
