Re: [PATCH 1/1 RFC] dmaengine: bcm2835: Remove redundant info from channel info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/25/2015 01:19 AM, Alexander Stein wrote:
On Tuesday 24 March 2015 20:12:23, Stephen Warren wrote:
On 03/24/2015 02:37 PM, Alexander Stein wrote:
There is no need to store the DREQ channel additionally in the channel
structure. This information is already stored in struct dma_slave_config
which is setup by bcm2835_dma_xlate.

Assuming this passes the smell test of the dmaengine maintainers, and
you've tested this in the upstream kernel,
Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx>

That currently my problem: I don't know how to actually test this. Do I need to setup a PCM playback? It seems this is currently the only (cyclic) DMA user in mainline kernel.
And what about that smell test? Is that CONFIG_DMATEST?

"Smell test" means the patch "smells" (appears/seems) OK to me.

Obviously I was wrong though:-)
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux