Hi Geert, Vinod > > --- a/include/linux/of_dma.h > > +++ b/include/linux/of_dma.h > > @@ -37,8 +37,8 @@ extern int of_dma_controller_register(struct device_node *np, > > (struct of_phandle_args *, struct of_dma *), > > void *data); > > extern void of_dma_controller_free(struct device_node *np); > > -extern struct dma_chan *of_dma_request_slave_channel(struct device_node *np, > > - const char *name); > > +struct dma_chan *of_dma_request_slave_channel(struct device_node *np, > > + const char *name); > > Why have you dropped the "extern" keyword? Checkpach? > All prototypes in the neighborhood have "extern" keywords, so I think it's > better to keep it for consistency. OK, I can fix it. But, this is very large patchset (24 patches !). I don't want to send all patches if possible. I will send only [01/24 v3] now. Please let me know if it is not OK. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
