Hi Arnd > How? shdma_chan_filter has this code > > /* Only support channels handled by this driver. */ > if (chan->device->device_alloc_chan_resources != > shdma_alloc_chan_resources) > return false; > > and that is only used by shdma_init(), which is called from > shdmac.c, sudmac.c, rcar-audmapp.c and rcar-hpbdma.c, but not > rcar-dmac.c > > > From compatibility/complexity from point of view, > > "audmapp independent from SH_DMAE_BASE" is easier than > > "fixup SH_DMAE_BASE for DT". > > Because no other R-Car SoC DMAC uses SH_DMAE_BASE driver > > Wouldn't this be enough to fix the bug (short term and for > backports, not in the long run)? Thanks ! I double checked audmapp's issue, and your idea seems solved my problem. > On a related topic, it seems you are very close to removing the > legacy sh_dmae_slave_config/hpb_dmae_slave_config arrays, the > only drivers that still rely on them are sound/soc/sh/siu_pcm.c, > drivers/usb/renesas_usbhs/fifo.c and drivers/tty/serial/sh-sci.c. > After those are converted to use dma_slave_config() and the normal > filter functions, a lot of obsolete code and data could just > go away. OK. I will investigate and work for these. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
