Hi Morimoto-san, Thank you for the patch. On Wednesday 21 January 2015 04:42:22 Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > The driver doesn't support residue reporting at all. > residue_granularity should be set to DMA_RESIDUE_GRANULARITY_DESCRIPTOR. > Special thanks to Laurent > > Reported-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> I thought the plan was to fix this in v4 of "[PATCH v3] dmaengine:: rcar- hpbdma: add dma_dev->directions" ? > --- > drivers/dma/sh/rcar-hpbdma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c > index 6fef1b9..749f26e 100644 > --- a/drivers/dma/sh/rcar-hpbdma.c > +++ b/drivers/dma/sh/rcar-hpbdma.c > @@ -600,7 +600,7 @@ static int hpb_dmae_probe(struct platform_device *pdev) > dma_dev->src_addr_widths = widths; > dma_dev->dst_addr_widths = widths; > dma_dev->directions = BIT(DMA_MEM_TO_DEV) | BIT(DMA_DEV_TO_MEM); > - dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST; > + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR; > > hpbdev->shdma_dev.ops = &hpb_dmae_ops; > hpbdev->shdma_dev.desc_size = sizeof(struct hpb_desc); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
