On Wed, 21 Jan 2015, Jiang Liu wrote: > On 2015/1/21 9:10, Rafael J. Wysocki wrote: > >> + > >> +void resource_list_insert(struct list_head *head, > >> + struct resource_list_entry *entry, bool tail) > > > > I would call this resource_list_add() if anything. > > > > Also it may be better to have two helpers, one for "add" and one for "add_tail" > > (and perhaps define them as static inline?). > We can't use inline functions here because that needs pulling list.h > into ioport.h, then causing building issues to header inclusion order. Create a new header file to avoid the circular dependencies then. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
