Hi Wolfram, Thank you for the patch. On Wednesday 14 January 2015 15:16:28 Wolfram Sang wrote: > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > And don't print an error: not configured is not an error. > > Reported-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> This looks good to me. Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > > In response to Philipp's patch silencing the warning in the driver: > http://patchwork.ozlabs.org/patch/425696/ > > I think this should be handled in the core. > > drivers/dma/of-dma.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c > index d5fbeaa1e7ba..ca31f1b45366 100644 > --- a/drivers/dma/of-dma.c > +++ b/drivers/dma/of-dma.c > @@ -159,6 +159,10 @@ struct dma_chan *of_dma_request_slave_channel(struct > device_node *np, return ERR_PTR(-ENODEV); > } > > + /* Silently fail if there is not even the "dmas" property */ > + if (!of_find_property(np, "dmas", NULL)) > + return ERR_PTR(-ENODEV); > + > count = of_property_count_strings(np, "dma-names"); > if (count < 0) { > pr_err("%s: dma-names property of node '%s' missing or empty\n", -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
