On Tue, Dec 30, 2014 at 08:04:51PM +0530, Shevchenko, Andriy wrote: > On Mon, 2014-12-22 at 20:36 +0530, Vinod Koul wrote: > > On Tue, Dec 16, 2014 at 11:40:01AM +0200, Andy Shevchenko wrote: > > > In case of the PCI driver we will get a warning: > > > dw_dmac_pci 0000:00:18.0: Unbalanced pm_runtime_enable! > > > dw_dmac_pci 0000:00:18.0: DesignWare DMA Controller, 8 channels > > > > > > This happens due to pm_runtime_enable() call from the driver when PM runtime is > > > enabled by core. > > > > > > This patch moves that call to the platform driver where it might make sense. > > Hmmm, sorry but it is not clear to me how moving it from core to platform > > helps solve the problem. > > In case of PCI driver we already have runtime PM enabled, meanwhile it's > not true for an ACPI case (since there is no _PS0 / _PS3 methods for the > DMA device). > > > Also this make more sense in core as it can be > > common acorss various devices > > We can enable it if it was disabled. okay, I see the point. But this patch fails to apply on rc1, can you please rebase and resend -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
