On Wed, Nov 05, 2014 at 03:21:39PM +0100, Krzysztof Kozlowski wrote:
> > > +static int __maybe_unused pl330_resume(struct device *dev)
> > > +{
> > > + struct amba_device *pcdev = to_amba_device(dev);
> > > +
> > > + amba_pclk_prepare(pcdev);
> > > +
> > > + /*
> > > + * TODO: Idea for future. The device should not be woken up after
> > > + * system resume if it is not needed. It could stay runtime suspended
> > > + * waiting for DMA requests. However for safe suspend and resume we
> > > + * forcibly resume the device here.
> > > + */
> > > + return pm_runtime_force_resume(dev);
> > > +}
> > > +
> > > +static SIMPLE_DEV_PM_OPS(pl330_pm, pl330_suspend, pl330_resume);
> > IIUC this sets .suspend and .resume, aren't you trying to add runtime
> > support as well?
> > Did you want UNIVERSAL_DEV_PM_OPS() ?
>
> The runtime suspend and resume callbacks are provided by amba/bus.c.
Can you add that as comment in this driver please.
rest looks fine
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
