Re: [PATCH 2/2] dmaengine: k3dma: Add CONFIG_PM_SLEEP to suspend/resume functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/27/2014 08:36 PM, Jingoo Han wrote:
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
build warning when CONFIG_PM_SLEEP is not selected. This is because
sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
the CONFIG_PM_SLEEP is enabled.

drivers/dma/k3dma.c:790:12: warning: 'k3_dma_suspend' defined but not used [-Wunused-function]
drivers/dma/k3dma.c:806:12: warning: 'k3_dma_resume' defined but not used [-Wunused-function]

Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>

Thanks Jingoo

Acked-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
---
  drivers/dma/k3dma.c |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index a1f911a..6029d1a 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -787,6 +787,7 @@ static int k3_dma_remove(struct platform_device *op)
  	return 0;
  }

+#ifdef CONFIG_PM_SLEEP
  static int k3_dma_suspend(struct device *dev)
  {
  	struct k3_dma_dev *d = dev_get_drvdata(dev);
@@ -816,6 +817,7 @@ static int k3_dma_resume(struct device *dev)
  	k3_dma_enable_dma(d, true);
  	return 0;
  }
+#endif

  static SIMPLE_DEV_PM_OPS(k3_dma_pmops, k3_dma_suspend, k3_dma_resume);


--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux