Hi Arnd, -----Original Message----- From: Arnd Bergmann [mailto:arnd@xxxxxxxx] Sent: Tuesday, October 21, 2014 2:45 PM To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Cc: Appana Durga Kedareswara Rao; devicetree@xxxxxxxxxxxxxxx; vinod.koul@xxxxxxxxx; Srikanth Vemula; linux-kernel@xxxxxxxxxxxxxxx; Srikanth Thokala; dmaengine@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx; Michal Simek; Anirudha Sarangi; grant.likely@xxxxxxxxxx; dan.j.williams@xxxxxxxxx Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support On Tuesday 21 October 2014 09:06:13 Appana Durga Kedareswara Rao wrote: > The above mentioned API's and structures will be used by the dma test > client driver's to set hardware configuration information. The dma > client drivers are not mainlined yet and it is Internally used by > our git-tree to test the DMA functionality in loopback . I would suggest you add the test driver into the main dmaengine driver file directly then, so you don't need to export the symbols. If there are important reasons to keep that as separate files, just move the header to the drivers/dma/ directory and add the test driver there. Arnd Sorry I forgot to mention the below things in the mail .The Config API's and structures not only used by the dmaengine driver's but also used by the various IP's (Ex: Ethernet driver and SRIO driver these drivers are under development).For example the Ethernet driver is resides under drivers/net/ethernet but it needs to set some specific configuration parameters of the dma that's why created a separate header file for the h/w configurable parameters. Regards, Kedar. This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html