On Tue, Oct 14, 2014 at 02:40:09PM +0200, Lars-Peter Clausen wrote: > On 10/14/2014 01:51 PM, Vinod Koul wrote: > >On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote: > >>The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and > >>'struct dma_pl330_desc desc' parameters for non-NULL. However these > >>checks are useless because supplied arguments won't be NULL. > >even if we have some error or bug? > > > >I would like this to be checked and complained loudly so we know something > >is going wrong rather than assuming it will be correct always. > > > > In this case it is impossible to get to this code portion if the > pointer is NULL because it would have crashed earlier. Yes checking again, for desc it seems not neccessary as its deref earlier in calling code and thrd shouldnt be NULL, so will apply now -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
