On Thu, Aug 28, 2014 at 01:44:38PM -0300, Fabio Estevam wrote:
> Remove the __init annotation from sdma_probe in order to fix the following
> warning:
>
> WARNING: drivers/dma/built-in.o(.data+0x2f4): Section mismatch in reference from
> the variable sdma_driver to the function .init.text:sdma_probe()
> The variable sdma_driver references the function __init sdma_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_consol
This was already fixed by Marks patch
commit e34b731faa7d12d3681187968ef899747e4feb55
Author: Mark Brown <broonie@xxxxxxxxxx>
Date: Wed Aug 27 11:55:53 2014 +0100
dma: imx-sdma: Remove spurious __init annotation on sdma_probe()
We can't annotate probe functions as __init since binding can occur at
any time, not just during kernel init.
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index c615e88..52ce1d2 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1448,7 +1448,7 @@ static struct dma_chan *sdma_xlate(struct
of_phandle_args *dma_spec,
return dma_request_channel(mask, sdma_filter_fn, &data);
}
-static int __init sdma_probe(struct platform_device *pdev)
+static int sdma_probe(struct platform_device *pdev)
{
const struct of_device_id *of_id =
of_match_device(sdma_dt_ids, &pdev->dev);
--
~Vinod
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> ---
> drivers/dma/imx-sdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index c615e88..52ce1d2 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1448,7 +1448,7 @@ static struct dma_chan *sdma_xlate(struct of_phandle_args *dma_spec,
> return dma_request_channel(mask, sdma_filter_fn, &data);
> }
>
> -static int __init sdma_probe(struct platform_device *pdev)
> +static int sdma_probe(struct platform_device *pdev)
> {
> const struct of_device_id *of_id =
> of_match_device(sdma_dt_ids, &pdev->dev);
> --
> 1.9.1
>
--
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
