On Tue, Sep 23, 2014 at 05:15:19PM +0800, Jingchang Lu wrote: > static u16 edma_readw(struct fsl_edma_engine *edma, void __iomem *addr) > { > - if (edma->big_endian) > - return ioread16be(addr); > - else > + u32 dst; This should be unsigned long, if it needs to exist. > + /* swap the reg offset for these in big-endian mode */ > + if (edma->big_endian) { > + dst = ((u32)addr & ~0x3) | (((u32)addr & 0x3) ^ 0x2); This can be simplified to: addr = (void __iomem *)((unsigned long)addr ^ 2); Ditto for all the other cases. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html