On 22 September 2014 11:46, Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> wrote: > Add amba_pclk_prepare() and amba_pclk_unprepare() macros for handling > the AMBA bus clock by device drivers. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > --- > include/linux/amba/bus.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h > index fdd7e1b61f60..ad52027a9cbf 100644 > --- a/include/linux/amba/bus.h > +++ b/include/linux/amba/bus.h > @@ -92,6 +92,12 @@ void amba_release_regions(struct amba_device *); > #define amba_pclk_disable(d) \ > do { if (!IS_ERR((d)->pclk)) clk_disable((d)->pclk); } while (0) > > +#define amba_pclk_prepare(d) \ > + (IS_ERR((d)->pclk) ? 0 : clk_prepare((d)->pclk)) You don't need the IS_ERR, because amba_probe will fail if it won't be able to fetch the clock. Same comment below. Kind regards Uffe > + > +#define amba_pclk_unprepare(d) \ > + do { if (!IS_ERR((d)->pclk)) clk_unprepare((d)->pclk); } while (0) > + > /* Some drivers don't use the struct amba_device */ > #define AMBA_CONFIG_BITS(a) (((a) >> 24) & 0xff) > #define AMBA_REV_BITS(a) (((a) >> 20) & 0x0f) > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html