Re: [PATCH] dmaengine: jz4740: Fix non-cyclic descriptor completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Sep 07, 2014 at 03:54:39PM +0200, Lars-Peter Clausen wrote:
> We need to make sure to deqeueue the descriptor from the active list before
> we call vchan_cookie_complete(). Also we need obviously only set chan->desc
> to NULL after we stopped using it.

Applied, thanks

-- 
~Vinod

> 
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
> ---
> Note this need not go into stable as there are no users of non-cyclic
> DMA transfers on jz4740 in stable.
> ---
>  drivers/dma/dma-jz4740.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c
> index 6a9d89c..ae2ab14 100644
> --- a/drivers/dma/dma-jz4740.c
> +++ b/drivers/dma/dma-jz4740.c
> @@ -362,8 +362,9 @@ static void jz4740_dma_chan_irq(struct jz4740_dmaengine_chan *chan)
>  			vchan_cyclic_callback(&chan->desc->vdesc);
>  		} else {
>  			if (chan->next_sg == chan->desc->num_sgs) {
> -				chan->desc = NULL;
> +				list_del(&chan->desc->vdesc.node);
>  				vchan_cookie_complete(&chan->desc->vdesc);
> +				chan->desc = NULL;
>  			}
>  		}
>  	}
> -- 
> 1.7.10.4
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux