Hi Laurent > > mid_rid > 0 : slave mode > > mid_rid = 0 : memcpy mode > > mid_rid < 0 : error > > Sorry, I spoke too fast. mid_rid == 0 is a valid hardware value in slave mode. > mid_rid < 0 denotes memcpy mode. Ahh, OK I understand. Thank you for your explaining > > This driver is counting driver users. > > So, I thought that we can initialize driver if it was 1st user. > > It could be done, but that would be more complex as the DMAC would be > reinitialized every time the use count increases from 0 to 1. I don't have strong objection to current method. So, you don't need to exchange it in v2 But, current code is doing MSTP ON -> device init -> MSTP OFF. and we will use this driver, like MSTP ON -> transfer -> MSTP OFF. My concern is that is this initialization really still enabled after MSTP OFF/ON ? Maybe this is OK current DMAC, but, we don't know future DMAC... -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
