On Sun, Jun 29, 2014 at 09:56:43PM +0200, Laurent Pinchart wrote: > Hi Wolfram, > > Thank you for the patch. > > On Sunday 29 June 2014 11:10:05 Wolfram Sang wrote: > > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > --- > > drivers/dma/sh/Makefile | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/dma/sh/Makefile b/drivers/dma/sh/Makefile > > index 1ce88b28cfc6..275297a89bd5 100644 > > --- a/drivers/dma/sh/Makefile > > +++ b/drivers/dma/sh/Makefile > > @@ -1,3 +1,6 @@ > > +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG > > Isn't this discouraged in favour of using dynamic printk ? I've recently > submitted a similar patch for the OMAP4 ISS driver and it got nacked. With dynamic debug, these flags dont make much sense unless you want something to be printed *always* during boot. unforuntely, this patch doesnt provide reason why we should do this here! -- ~Vinod > > > +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG > > + > > obj-$(CONFIG_SH_DMAE_BASE) += shdma-base.o shdma-of.o > > obj-$(CONFIG_SH_DMAE) += shdma.o > > shdma-y := shdmac.o > > -- > Regards, > > Laurent Pinchart > -- -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
