Re: [PATCH 2/3] dmaengine: sh: fix print specifier warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Vinod,

Thank you for the patch.

On Monday 02 June 2014 09:48:23 Vinod Koul wrote:
> As documented in Documentation/printk-formats.txt we should use %zu/%zx
> specifiers for size_t type variables for the code to compile on different
> architectures. This is uncovered as COMPILE_TEST has been enabled recently
> for this driver
> 
>    drivers/dma/sh/shdma-base.c: In function 'shdma_prep_dma_cyclic':
> >> drivers/dma/sh/shdma-base.c:683:4: warning: format '%d' expects argument
> >> of
> >> type 'int', but argument 4 has type 'size_t' [-Wformat=]
> 
>        __func__, buf_len, period_len, slave_id);
> 
> >> drivers/dma/sh/shdma-base.c:683:4: warning: format '%d' expects argument
> >> of type 'int', but argument 5 has type 'size_t' [-Wformat=]
> 
> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/dma/sh/shdma-base.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
> index 66b4a35..591b9d8 100644
> --- a/drivers/dma/sh/shdma-base.c
> +++ b/drivers/dma/sh/shdma-base.c
> @@ -679,7 +679,7 @@ static struct dma_async_tx_descriptor
> *shdma_prep_dma_cyclic( /* Someone calling slave DMA on a generic channel?
> */
>  	if (slave_id < 0 || (buf_len < period_len)) {
>  		dev_warn(schan->dev,
> -			"%s: bad parameter: buf_len=%d, period_len=%d, id=%d\n",
> +			"%s: bad parameter: buf_len=%zu, period_len=%zu, id=%d\n",
>  			__func__, buf_len, period_len, slave_id);
>  		return NULL;
>  	}

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux