Hi Vinod,
On Wed, Apr 30, 2014 at 12:34:08PM +0530, Vinod Koul wrote:
> > +
> > +static int sun6i_dma_terminate_all(struct sun6i_vchan *vchan)
> > +{
> > + struct sun6i_dma_dev *sdev = to_sun6i_dma_dev(vchan->vc.chan.device);
> > + struct sun6i_pchan *pchan = vchan->phy;
> > + unsigned long flags;
> > + LIST_HEAD(head);
> > +
> > + spin_lock(&sdev->lock);
> > + list_del_init(&vchan->node);
> > + spin_unlock(&sdev->lock);
> > +
> > + spin_lock_irqsave(&vchan->vc.lock, flags);
> > +
> > + vchan_get_all_descriptors(&vchan->vc, &head);
> > +
> > + if (pchan) {
> > + writel(DMA_CHAN_ENABLE_STOP, pchan->base + DMA_CHAN_ENABLE);
> > + writel(DMA_CHAN_PAUSE_RESUME, pchan->base + DMA_CHAN_PAUSE);
> > +
> > + vchan->phy = NULL;
> > + pchan->vchan = NULL;
> > + pchan->desc = NULL;
> > + pchan->done = NULL;
> > + }
> > +
> > + spin_unlock_irqrestore(&vchan->vc.lock, flags);
> > +
> > + vchan_dma_desc_free_list(&vchan->vc, &head);
>
> shouldn't you kill the tasklet as well here?
Just to be clear, which tasklet? vchan's or the driver's?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
