Hi Andy, On Tuesday 13 May 2014 11:14:20 Andy Shevchenko wrote: > On Tue, 2014-05-13 at 01:02 +0200, Laurent Pinchart wrote: > > This helps detecting duplicate includes. > > No need to do that, since we have nice helper > make includecheck We do, but it's much quicker and easier to spot the duplicate visually when modifying the source code than having to run an external script. > Similar comment to patch 3/6. > But if you have stronger explanation why it's needed besides that... you > are welcome ) > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > > > drivers/dma/sh/shdmac.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c > > index dda7e75..7313537 100644 > > --- a/drivers/dma/sh/shdmac.c > > +++ b/drivers/dma/sh/shdmac.c > > @@ -18,21 +18,21 @@ > > > > * > > */ > > > > +#include <linux/delay.h> > > +#include <linux/dmaengine.h> > > > > #include <linux/init.h> > > > > +#include <linux/interrupt.h> > > +#include <linux/kdebug.h> > > > > #include <linux/module.h> > > > > +#include <linux/notifier.h> > > > > #include <linux/of.h> > > #include <linux/of_device.h> > > > > -#include <linux/slab.h> > > -#include <linux/interrupt.h> > > -#include <linux/dmaengine.h> > > -#include <linux/delay.h> > > > > #include <linux/platform_device.h> > > #include <linux/pm_runtime.h> > > > > +#include <linux/rculist.h> > > > > #include <linux/sh_dma.h> > > > > -#include <linux/notifier.h> > > -#include <linux/kdebug.h> > > +#include <linux/slab.h> > > > > #include <linux/spinlock.h> > > > > -#include <linux/rculist.h> > > > > #include "../dmaengine.h" > > #include "shdma.h" -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
