On 04/29/2014 03:46 AM, Vinod Koul wrote: [..] > commit 770f0f3a20188b7e17db2790803b9da925dc0b94 > Author: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Date: Mon Apr 28 10:49:43 2014 +0000 > > dmaengine: edma: Make reading the position of active channels work > > As Joel pointed out, edma_read_position() uses memcpy_fromio() to read > the parameter ram. That's not synchronized with the internal update as > it does a byte by byte copy. We need to do a 32bit read to get a > consistent value. > > Further reading destination and source is pointless. In DEV_TO_MEM > transfers we are only interested in the destination, in MEM_TO_DEV we > care about the source. In MEM_TO_MEM it really does not matter which > one you read. > > Simple solution: Remove the pointers, select dest/source via a bool > and return the read value. > > Remove the export of this function while at it. The only potential > user is the dmaengine and that's always builtin. > > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > > You s-o-b missing in this one, also ack from Sekhar missing. Do you want to redo > this or prefer me to cherry-pick patches adding acks and your s-o-b, since I > already fetched your branch > > Either way is fine with me... > If its Ok with you, it would great if you could add my Ack and Sob. Thanks a lot. Let me know if you'd want me to do anything else here. Regards, -Joel -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
