Re: [patch] dmaengine: sirf: off by one in of_dma_sirfsoc_xlate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2014-04-03 15:29 GMT+08:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>:
> The ">" here should be ">=" or we are one step beyond the end of the
> sdma->channels[] array.
>
> Fixes: 2e041c94628c ('dmaengine: sirf: enable generic dt binding for dma channels')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>

Acked-by: Barry Song <Baohua.Song@xxxxxxx>

> diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c
> index a1bd829..03f7820 100644
> --- a/drivers/dma/sirf-dma.c
> +++ b/drivers/dma/sirf-dma.c
> @@ -666,7 +666,7 @@ static struct dma_chan *of_dma_sirfsoc_xlate(struct of_phandle_args *dma_spec,
>         struct sirfsoc_dma *sdma = ofdma->of_dma_data;
>         unsigned int request = dma_spec->args[0];
>
> -       if (request > SIRFSOC_DMA_CHANNELS)
> +       if (request >= SIRFSOC_DMA_CHANNELS)
>                 return NULL;
>
>         return dma_get_slave_channel(&sdma->channels[request].chan);
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux PCI]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux