Hi Andriy,
On Wed, Mar 05, 2014 at 02:07:55PM +0000, Shevchenko, Andriy wrote:
> > + return PTR_ERR(pll6);
> > + }
> > +
> > + ret = clk_set_parent(mux, pll6);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Couldn't reparent AHB1 on PLL6\n");
> > + return ret;
> > + }
> > +
> > + devm_clk_put(&pdev->dev, mux);
> > + devm_clk_put(&pdev->dev, pll6);
>
> Since you put those here, would it be better to use plain
> clk_get/clk_put ?
Actually, this allows to have no exit path for the case where one of
the calls between the first clk_get, and here. devm_clk_* makes error
handling much easier here, that's just all
I'll fix the other comments you had, and send a new version.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Attachment:
signature.asc
Description: Digital signature
