On Mon, Mar 03, 2014 at 09:38:03AM +0000, Shevchenko, Andriy wrote:
<snip>
> > + if (IS_ERR(bdev->bamclk))
> > + return PTR_ERR(bdev->bamclk);
> > +
> > + ret = clk_prepare_enable(bdev->bamclk);
> > + if (ret) {
> > + dev_err(bdev->dev, "failed to prepare/enable clock\n");
> > + return ret;
> > + }
> > +
> > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,ee", &bdev->ee);
> > + if (ret) {
> > + dev_err(bdev->dev, "Execution environment unspecified\n");
> > + return ret;
>
> goto err_disable_clk; ?
>
> >
> > + }
> > +
> > + ret = bam_init(bdev);
> > + if (ret)
> > + return ret;
>
> Ditto.
>
Good catch. I'll fix both of those.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
