Re: [PATCH v3 2/2] dm-integrity: introduce ahash support for the internal hash

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 4 Feb 2025, Harald Freudenberger wrote:

> Thanks Mikulas for your feedback.
> As of now all this looks like a dead end to our attempt on trying to
> provide a phmac-shaxxx digest for use with dm-integrity. Thanks for
> your effort. Don't expect another version of this patch as I can't
> fullfill the requirements.

Hi

I think that it is possible to make it work for you with async-only 
hashes.

As for calling integrity_sector_checksum from dm_integrity_end_io - we can 
offload this operation to a workqueue when using an async hash.

As for memory allocation in the I/O path - we can move the sector_le and 
ahash_request fields to the structure dm_integrity_io. So, that there is 
no allocation in the I/O path.

I fixed your patches and I'll send them in the next email - please test 
them.

I tested them with the cryptsetup testsuite (and I hacked the code so that 
it prefers ahash over shash) and it passed.

Mikulas





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux