On Mon, Jan 20, 2025 at 04:16:26PM +0100, Mikulas Patocka wrote: > Some SATA SSDs and most NVMe SSDs report physical block size 512 bytes, > but they use 4K remapping table internally and they do slow > read-modify-write cycle for requests that are not aligned on 4K boundary. > Therefore, io_opt should be aligned on 4K. Not really. I mean it's always smart to not do tiny unaligned I/O unless you have to. So we're not just going to cap an exported value to a magic number because of something. > Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx> > Fixes: a23634644afc ("block: take io_opt and io_min into account for max_sectors") > Fixes: 9c0ba14828d6 ("blk-settings: round down io_opt to physical_block_size") Please explain how this actually is a fix.