Re: [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Damien,

kernel test robot noticed the following build warnings:

[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on linus/master v6.13-rc1 next-20241205]
[cannot apply to device-mapper-dm/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Damien-Le-Moal/block-Use-a-zone-write-plug-BIO-work-for-REQ_NOWAIT-BIOs/20241206-095452
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20241206015240.6862-5-dlemoal%40kernel.org
patch subject: [PATCH 4/4] dm: Fix dm-zoned-reclaim zone write pointer alignment
config: arc-randconfig-002-20241206 (https://download.01.org/0day-ci/archive/20241206/202412061404.Utec5WgH-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412061404.Utec5WgH-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412061404.Utec5WgH-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> block/blk-zoned.c:1751: warning: Excess function parameter 'flags' description in 'blkdev_issue_zone_zeroout'


vim +1751 block/blk-zoned.c

  1735	
  1736	/**
  1737	 * blkdev_issue_zone_zeroout - zero-fill a block range in a zone
  1738	 * @bdev:	blockdev to write
  1739	 * @sector:	start sector
  1740	 * @nr_sects:	number of sectors to write
  1741	 * @gfp_mask:	memory allocation flags (for bio_alloc)
  1742	 * @flags:	controls detailed behavior
  1743	 *
  1744	 * Description:
  1745	 *  Zero-fill a block range in a zone (@sector must be equal to the zone write
  1746	 *  pointer), handling potential errors due to the (initially unknown) lack of
  1747	 *  hardware offload (See blkdev_issue_zeroout()).
  1748	 */
  1749	int blkdev_issue_zone_zeroout(struct block_device *bdev, sector_t sector,
  1750			sector_t nr_sects, gfp_t gfp_mask)
> 1751	{
  1752		int ret;
  1753	
  1754		if (WARN_ON_ONCE(!bdev_is_zoned(bdev)))
  1755			return -EIO;
  1756	
  1757		ret = blkdev_issue_zeroout(bdev, sector, nr_sects, gfp_mask,
  1758					   BLKDEV_ZERO_NOFALLBACK);
  1759		if (ret != -EOPNOTSUPP)
  1760			return ret;
  1761	
  1762		/*
  1763		 * The failed call to blkdev_issue_zeroout() advanced the zone write
  1764		 * pointer. Undo this using a report zone to update the zone write
  1765		 * pointer to the correct current value.
  1766		 */
  1767		ret = disk_zone_sync_wp_offset(bdev->bd_disk, sector);
  1768		if (ret != 1)
  1769			return ret < 0 ? ret : -EIO;
  1770	
  1771		/*
  1772		 * Retry without BLKDEV_ZERO_NOFALLBACK to force the fallback to a
  1773		 * regular write with zero-pages.
  1774		 */
  1775		return blkdev_issue_zeroout(bdev, sector, nr_sects, gfp_mask, 0);
  1776	}
  1777	EXPORT_SYMBOL(blkdev_issue_zone_zeroout);
  1778	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux