On Thu, Nov 21, 2024 at 01:46:17PM -0500, Benjamin Marzinski wrote:
> On Thu, Nov 21, 2024 at 06:05:48PM +0100, Martin Wilck wrote:
> > On Wed, 2024-11-20 at 19:17 -0500, Benjamin Marzinski wrote:
> > > In libmp_mapinfo__(), if is_mpath_part_uuid() succeeded, instead of
> > > ending the 'if' statement, is_mpath_uuid() would be called because of
> > > the OR operator. This would always fail if is_mpath_part_uuid()
> > > passed.
> > > This meant that libmp_mapinfo__() could never match partitions with
> > > MAPINFO_CHECK_UUID.
> > >
> > > Fix that by not calling is_mpath_uuid() if MAPINFO_PART_ONLY is set.
> > >
> > > Fixes: c1aa0285 ("libmultipath: make MAPINFO_CHECK_UUID work with
> > > partitions")
> > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> >
> > Ouch. Thanks!!
> > Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
>
> So, in theory the next step would be to open a PR for the upstream
> stable branch, if that existed, right?
But I suppose the better actual plan here is just to update the 0.11.0
PR.
>
> -Ben
