Re: [RFC PATCH] 11-dm-mpath.rules: Disable blkid runs when updating the device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2024-10-22 at 19:33 -0400, Benjamin Marzinski wrote:
> When multipath reloads a device or fails or restores a path, the udev
> rules disable LVM scanning, but since .DM_NOSCAN isn't set, blkid is
> still run on the device. When multipath devices that are set to
> queue_if_no_path lose all their paths at close to the same time, udev
> workers can hang trying to run blkid. The blkid results shouldn't
> change when multipathd is adding, removing, failing or reinstating
> paths, aside from avoiding hanging udev processes, we're skipping
> unnecessary work.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> ---
>  multipath/11-dm-mpath.rules.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This is correct. It conflicts with my own late udev rule patch set.
While your patch was sent first, I believe it makes more sense to apply
this change after mine.

I'll to send a v2 with the .DM_NOSCAN logic improved.

Regards
Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux