Since we just returned if newstate wasn't PATH_UP or PATH_GHOST, it
must obviously be PATH_UP or PATH_GHOST at this point in the code. We
don't even wrap all the code for dealing with a path that just came up
in this if-block, It's only the persistent resrvation code.
Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
---
multipathd/main.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/multipathd/main.c b/multipathd/main.c
index d479d0c0..ec172021 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -2550,19 +2550,19 @@ update_path_state (struct vectors * vecs, struct path * pp)
return CHECK_PATH_CHECKED;
}
- if (newstate == PATH_UP || newstate == PATH_GHOST) {
- if (pp->mpp->prflag != PRFLAG_UNSET) {
- int prflag = pp->mpp->prflag;
- /*
- * Check Persistent Reservation.
- */
- condlog(2, "%s: checking persistent "
- "reservation registration", pp->dev);
- mpath_pr_event_handle(pp);
- if (pp->mpp->prflag == PRFLAG_SET &&
- prflag != PRFLAG_SET)
- pr_register_active_paths(pp->mpp);
- }
+ /* newstate == PATH_UP || newstate == PATH_GHOST */
+
+ if (pp->mpp->prflag != PRFLAG_UNSET) {
+ int prflag = pp->mpp->prflag;
+ /*
+ * Check Persistent Reservation.
+ */
+ condlog(2, "%s: checking persistent "
+ "reservation registration", pp->dev);
+ mpath_pr_event_handle(pp);
+ if (pp->mpp->prflag == PRFLAG_SET &&
+ prflag != PRFLAG_SET)
+ pr_register_active_paths(pp->mpp);
}
/*
--
2.45.0
