On Thu, Oct 03, 2024 at 05:41:52PM -0700, Eric Biggers wrote: > From: Eric Biggers <ebiggers@xxxxxxxxxx> > > Add a new device-mapper target "dm-inlinecrypt" that is similar to > dm-crypt but uses the blk-crypto API instead of the regular crypto API. > This allows it to take advantage of inline encryption hardware such as > that commonly built into UFS host controllers. > > The table syntax matches dm-crypt's, but for now only a stripped-down > set of parameters is supported. For example, for now AES-256-XTS is the > only supported cipher. Maybe I'm stepping into a mine-field here, but if this simply uses blk-crypto to accellerate a subset of dm-crypt, why isn't dm-crypt simply enhanced to use blk-crypto when available? compatible, > +EXPORT_SYMBOL_GPL(bio_crypt_set_ctx); Please split the exports in a separate subsystem into a separate prep patch, documenting why it makes sense to have these as exported APIs.
