Re: [PATCH 16/22] multipathd: correctly handle paths removed for a wwid change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 15, 2024 at 09:16:32PM +0200, Martin Wilck wrote:
> On Sat, 2024-07-13 at 02:05 -0400, Benjamin Marzinski wrote:
> > If check_path() exitted because the path's wwid changed and it was
> > removed, checkerloop() wasn't decrementing the pathvec loop count.
> > This caused the next path to be skipped by the checker loop.
> > 
> > To solve this, make check_path() return -1 when a path is removed,
> > make handle_uninitialized_path() also remove the path if it was
> > blacklisted, and make checkerloop() just decrement the loop count
> > when a path returns -1.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> 
> Would you mind making these return values symbolic? Other than that,
> LGTM.

Yeah, I can do that.


> 
> Martin





[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux