Re: [PATCH 09/22] multipathd: set pp->tick = max_checkint in handle_uninitialized_path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2024-07-13 at 02:04 -0400, Benjamin Marzinski wrote:
> When handle_uninitialized_path() checks a path, it will either:
> 1. trigger a new uevent to initalize the path, in which case it won't
>    check the path again until that uevent is processed and updates
>    pp->tick
> 2. blacklist the path, in which case the path gets removed
> 3. intialize the path correctly, in which case it sets pp->tick = 1
> 4. fail to initialize the path, in which case it was supposed to set
>    pp->tick to max_checkint, but instead it set pp->checkint to
>    max_checkint, which never worked correctly.
> 
> By setting pp->tick to max_checkint at the start,
> handle_uninitialized_path() will continue to work as it previously
> did,
> except in case 4, where in now works correctly. There's no point in
> messing with pp->checkint for paths that haven't been initialized
> yet.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>

Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>

Q: I suppose it makes sense to backport this to earlier releases?

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux