Re: [PATCH 05/22] multipathd: handle uninitialized paths in new function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-07-15 at 17:34 +0200, Martin Wilck wrote:
> On Sat, 2024-07-13 at 02:04 -0400, Benjamin Marzinski wrote:
> > Pull the code to handle uninitialized paths out of check_path() and
> > into
> > a new function called handle_uninitialized_paths(). This should
> > cause
> > no functional changes.
> > 
> > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
> > ---
> >  multipathd/main.c | 171 ++++++++++++++++++++++++++++--------------
> > --
> > --
> >  1 file changed, 105 insertions(+), 66 deletions(-)
> 
> !pp->mpp always holds if this function is called, so we can skip this
> part of the test.
> 

Just realized that you did this in patch 7.

LGTM, then, but if you resubmit, I suggest you just squash these two.

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux