Re: [PATCH 42/44] llibmultipath: fix return code check for dm_is_suspended()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2024-07-11 at 02:27 -0400, Benjamin Marzinski wrote:
> On Tue, Jul 09, 2024 at 11:39:33PM +0200, Martin Wilck wrote:
> > dm_is_suspended returns non-null if it failed to obtain the device
> > information. It's wrong to assume in this case that the device is
> > suspended.
> 
> I'm kinda torn on this one. Sure we don't know if the device is
> suspended, and most likely if this failed, the device got removed. 
> But
> on the other hand, it could have failed for another reason, and
> resuming
> a device that isn't suspended (or doesn't exist) causes no harm.

In theory, a resume operation might swap the live and inactive table.
But it practice, that can't happen. It's a corner case anyway.

I'll drop this one.

Martin






[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux