On Wed, 2024-07-10 at 12:30 -0400, Benjamin Marzinski wrote:
> On Tue, Jul 09, 2024 at 11:38:57PM +0200, Martin Wilck wrote:
> > The path for kpartx should match the installed binary.
> >
> > Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> > ---
> > .gitignore | 1 +
> > kpartx/Makefile | 4 ++--
> > kpartx/{kpartx.rules => kpartx.rules.in} | 2 +-
> > 3 files changed, 4 insertions(+), 3 deletions(-)
> > rename kpartx/{kpartx.rules => kpartx.rules.in} (96%)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 049ffe8..355ddbb 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -12,6 +12,7 @@ config.mk
> > cscope.files
> > cscope.out
> > kpartx/kpartx
> > +kpartx/kpartx.rules
> > multipath/multipath
> > multipath/multipath.8
> > multipath/multipath.conf.5
> > diff --git a/kpartx/Makefile b/kpartx/Makefile
> > index 7720a74..0d4c798 100644
> > --- a/kpartx/Makefile
> > +++ b/kpartx/Makefile
>
> Shouldn't we have
>
> all: $(EXEC) kpartx.rules
>
> so that kpartx.rules gets create when running "make", like happens in
> the
> other makefiles?
>
Good catch, thanks!
Martin
