On Thu, 2024-06-27 at 14:48 -0400, Benjamin Marzinski wrote: > On Thu, Jun 27, 2024 at 11:27:41AM +0200, Martin Wilck wrote: > > On Wed, 2024-06-05 at 19:22 -0400, Benjamin Marzinski wrote: > > > add arguments to dm_map_present_by_uuid() to allow optionally > > > fetching > > > the device name and minor number for the devices found by WWID. > > > These > > > will be used by a later patch. > > > > > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> > > > > I have to say I don't like this much. At least the function name > > should > > be changed. But actually, our handling of DM_DEVICE_INFO and > > DM_DEVICE_STATUS dm tasks needs refactoring. As far as the kernel > > is > > concerned, all dm ioctls that refer to an existing map will find > > the > > map either by uuid, by name, or by major/minor, and the map uuid > > and > > name will always be filled in. > > > > I'll see if I can come up with something to clean this up. > > Do you want be to resend this patch with a name change, or will that > just happen as part of your cleanup? Please give me a day or two. I'm working on the cleanup, which has grown quite a bit. I hope to be able to send it tomorrow. Martin
