On Wed, 2024-06-05 at 19:22 -0400, Benjamin Marzinski wrote: > > cli_add_map() runs filter_wwid() on the input param as if it were a > WWID, but dm_get_major_minor() will never find the multipath device > if > the user actually passes in a WWID. To handle this case, call > get_refwwid() early in the function, and use dm_map_present_by_uuid() > to > check if the map exists, and find its alias and minor number. > > Also, the do/while loop is unnecessarily confusing and only avoids > one > repeated function call. Remove it to simplify the cli_add_map(). > > Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx> Looks good, but it depends on 4/7, which needs some work. Martin
