On Wed, 2024-06-05 at 19:22 -0400, Benjamin Marzinski wrote:
> Forgot the comparison in the "if" statement.
>
> Fixes 8a3898339 ("multipathd: sync features on flush_map failure
> corner case")
>
> Signed-off-by: Benjamin Marzinski <bmarzins@xxxxxxxxxx>
Ups. The reviewer was asleep, it seems.
Reviewed-by: Martin Wilck <mwilck@xxxxxxxx>
(Btw, I am sorry for the long delay of this review).
> ---
> multipathd/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index 09286dd0..58afe14a 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -813,7 +813,7 @@ flush_map(struct multipath * mpp, struct vectors
> * vecs)
> {
> int r = dm_suspend_and_flush_map(mpp->alias, 0);
> if (r != DM_FLUSH_OK) {
> - if (DM_FLUSH_FAIL_CANT_RESTORE)
> + if (r == DM_FLUSH_FAIL_CANT_RESTORE)
> remove_feature(&mpp->features,
> "queue_if_no_path");
> condlog(0, "%s: can't flush", mpp->alias);
> return r;
