Re: [PATCH v3 6/8] fsverity: improve performance by using multibuffer hashing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 03, 2024 at 11:50:02AM -0700, Eric Biggers wrote:
>
> I've now unified the code paths for single-block and multi-block processing in
> fsverity and dm-verity, which I think addresses your remaining concern that's
> feasible to address.  Your feedback has been conflating different issues, and it
> only comes in once every few weeks, so it's a bit hard to follow.  But I think
> the remaining thing that you're asking for is to make the API to be part of
> "ahash" and use the existing async completion callback.  That's not actually
> feasible, for the reasons that I've explained in detail.  See in particular
> https://lore.kernel.org/linux-crypto/20240503152810.GA1132@sol.localdomain/.

I've tried to dedicate more time to your patches, but sending
them in just before a merge window is a sure way to add extra
delay before I get a chance to review them.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt




[Index of Archives]     [DM Crypt]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Packaging]     [Fedora SELinux]     [Yosemite Discussion]     [KDE Users]     [Fedora Docs]

  Powered by Linux