* Matthew Sakai (msakai@xxxxxxxxxx) wrote:
> On 5/23/24 17:07, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >
> > 'uds_attribute' is unused since
> > commit a9da0fb6d8c6 ("dm vdo: remove all sysfs interfaces").
> >
> > Remove it.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
>
> Yes, this was clearly an oversight on our part. Feel free to add:
> Reviewed-by: Matthew Sakai <msakai@xxxxxxxxxx>
Thanks for the quick review.
Is this something you'll send a pull for, or do I need to
ask someone else to include it?
Dave
> > ---
> > drivers/md/dm-vdo/dedupe.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/md/dm-vdo/dedupe.c b/drivers/md/dm-vdo/dedupe.c
> > index 117266e1b3ae..39ac68614419 100644
> > --- a/drivers/md/dm-vdo/dedupe.c
> > +++ b/drivers/md/dm-vdo/dedupe.c
> > @@ -148,11 +148,6 @@
> > #include "vdo.h"
> > #include "wait-queue.h"
> > -struct uds_attribute {
> > - struct attribute attr;
> > - const char *(*show_string)(struct hash_zones *hash_zones);
> > -};
> > -
> > #define DEDUPE_QUERY_TIMER_IDLE 0
> > #define DEDUPE_QUERY_TIMER_RUNNING 1
> > #define DEDUPE_QUERY_TIMER_FIRED 2
>
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
