On Wed, May 15, 2024 at 10:37:55AM +0200, Peter Zijlstra wrote: > On Tue, May 14, 2024 at 04:47:19PM +0800, Kuan-Wei Chiu wrote: > > Modify the min_heap_push() and min_heap_pop() to return a boolean > > value. They now return false when the operation fails and true when it > > succeeds. > > But why ?! like Kuan said, it makes for cleaner code. It's also what the bcache/bcachefs heap (and fifo) implementations do, which we're consolidating.