> > +static inline void disk_zone_wplug_set_error(struct gendisk *disk, > + struct blk_zone_wplug *zwplug) > +{ > + if (!(zwplug->flags & BLK_ZONE_WPLUG_ERROR)) { Can you just do an early return if the flag is not set instead of all the extra indentation? > +static inline void disk_zone_wplug_clear_error(struct gendisk *disk, > + struct blk_zone_wplug *zwplug) > +{ > + if (zwplug->flags & BLK_ZONE_WPLUG_ERROR) { Same here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>