On Wed, 17 Apr 2024, Damien Le Moal wrote: > On 2024/04/16 0:23, Mikulas Patocka wrote: > >>> @@ -119,4 +120,16 @@ extern void complete(struct completion * > >>> extern void complete_on_current_cpu(struct completion *x); > >>> extern void complete_all(struct completion *); > >>> > >>> +static inline void blk_wait_io(struct completion *done) > >> > >> Since you move this function outside of the block layer, the "blk_" prefix seems > >> out of place. What about renaming this to something like > >> "wait_for_completion_blk_io()", or to make it clear that it is not the same as > >> wait_for_completion_io(), may be "wait_for_completion_long_io()" ? > > > > Yes. Here I'm sending a second patch that renames this function to > > wait_for_completion_long_io. > > This looks good to me, but you sent this new version as a reply. Please post a > properly formatted new patch. And since you are touching the block layer, this > needs to be sent to linux-block and Jens as well. OK. I've resent it. Mikulas
