On 3/18/24 16:54, Guenter Roeck wrote:
On 3/18/24 13:37, Kenneth Raeburn wrote:
(resend because of accidental HTML lossage)
On Thu, Mar 14, 2024 at 7:38 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
On sparc64, with gcc 11.4, the above code results in:
ERROR: modpost: "__bswapdi2" [drivers/md/dm-vdo/dm-vdo.ko] undefined!
Guenter
Thanks for catching that. I don't think our team has any sparc
machines readily available for testing.
This is an artifact of our having imported user-mode code to use in
the kernel. We should probably be using le64_to_cpup and friends, as
we do elsewhere, so it doesn't try to pull in libgcc support routines.
I am kind of getting wary about reporting such issues. Should I drop
building dm-vdo images for sparc ? Would it be possible to add
"depends on BROKEN if SPARC" configuration option to indicate that
the code isn't expected to be buildable on sparc, much less work ?
First off, sorry for the slow response. I was away for the last couple
of days.
I would encourage you to report issues when you find them.
Theoretically, VDO should work on sparc. However since we don't have
that architecture readily available to us, we won't know what to fix
unless it gets reported.
In this case, we really shouldn't be relying on these libgcc builtins
anyway. I hope to have a patch in a couple of days that you can try out.
If it turns out there are more extensive issues with VDO on sparc, I am
open to disabling the config, but I hope it won't come to that.
Matt
