On 3/5/24 13:05, Martin Wilck wrote: > Martin Wilck (7): > 13-dm-disk.rules: import ID_FS_TYPE > 10-dm.rules: test DISK_RO after importing properties > 10-dm-rules: don't restore DM_UDEV_DISABLE_OTHER_RULES_FLAG from db > 11-dm-lvm.rules: don't restore DM_UDEV_DISABLE_OTHER_RULES_FLAG from > db > dm udev rules: don't export and save DM_SUSPENDED > dm udev rules: don't export and save DM_NOSCAN > 10-dm.rules: bump DM_UDEV_RULES_VSN to 3 > > udev/10-dm.rules.in | 43 +++++++++++++++++++++++++++--------- > udev/11-dm-lvm.rules.in | 13 +++++------ > udev/12-dm-permissions.rules | 2 +- > udev/13-dm-disk.rules.in | 9 ++++---- > 4 files changed, 43 insertions(+), 24 deletions(-) > Only really minor and cosmetic things: - we're using $env instead of %E to reference the variables, - maybe let's dump the mention about DM_SUSPENDED in 12-dm-permissions.rules if we're at it But functionality-wise looks good as already discussed in the RFC version of the patchset. Thank you! (You can also create an MR in lvm2's gitlab upstream repo https://gitlab.com/lvmteam/lvm2 if you have an account there.) For the whole patchset: Reviewed-by: Peter Rajnoha <prajnoha@xxxxxxxxxx> -- Peter
